Skip to content

Remove support for building without Arrow #1683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

Remove support for building without Arrow #1683

merged 1 commit into from
May 27, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented May 26, 2021 •
edited
Loading

📔 Description

This removes the previously deprecated build option -DVAST_ENABLE_ARROW=OFF.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

To be merged after the May release. This should all be covered by CI.

@dominiklohmann dominiklohmann added maintenance Tasks for keeping up the infrastructure blocked Blocked by an (external) issue labels May 26, 2021
@dominiklohmann dominiklohmann requested a review from a team May 26, 2021 10:05
@dominiklohmann dominiklohmann force-pushed the story/ch25719/remove-without-arrow branch 2 times, most recently from 3302586 to e077b83 Compare May 26, 2021 11:33
@dominiklohmann dominiklohmann force-pushed the story/ch25719/deprecate-without-arrow branch from abe2597 to b6246ed Compare May 26, 2021 13:39
@dominiklohmann dominiklohmann force-pushed the story/ch25719/remove-without-arrow branch from e077b83 to f1030af Compare May 26, 2021 13:53
Base automatically changed from story/ch25719/deprecate-without-arrow to master May 26, 2021 14:07
@dominiklohmann dominiklohmann force-pushed the story/ch25719/remove-without-arrow branch from f1030af to 2ad7228 Compare May 26, 2021 14:20
@dominiklohmann
Remove support for building without Arrow
7e5e7b0 
This removes the previously deprecated build option
`-DVAST_ENABLE_ARROW=OFF`.
@dominiklohmann dominiklohmann force-pushed the story/ch25719/remove-without-arrow branch from 2ad7228 to 7e5e7b0 Compare May 26, 2021 16:11
@dominiklohmann dominiklohmann removed the blocked Blocked by an (external) issue label May 27, 2021
@dominiklohmann dominiklohmann enabled auto-merge May 27, 2021 13:34
tobim
tobim approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that we won't have to deal with that corner case any more. I trust CI that this change doesn't break anything unintentionally.

@dominiklohmann dominiklohmann merged commit 17daea9 into master May 27, 2021
@dominiklohmann dominiklohmann deleted the story/ch25719/remove-without-arrow branch May 27, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim