Fix a bunch of smaller issues #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Makefile for ClangBuildAnalyzer is defunct on macOS. Additionally, this changes the CMake to use the minimal necessary include for checking compiler flag availability.
dominiklohmann
force-pushed
the
topic/small-fixups
branch
9 times, most recently
from
4260d5b to
6ecde9f
Compare
tobim
requested changes
May 31, 2021
In absolutely unscientific experiments, this sped up build time a fair bit. Requires CMake>=3.16, but since it doesn't really change the compiled binary we can just make it optional depending on the actual CMake version instead of bumping the minimum requirement.
dominiklohmann
force-pushed
the
topic/small-fixups
branch
from
6ecde9f to
103ad35
Compare
tobim
approved these changes
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
These commits don't have much to do with each other, but these are four things that I have noticed recently, none of which are changelog-worthy.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.