Make unix dgram metrics sink connectionless #1702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way of setting up the UDS datagram metrics relied on a fake connection that made it possible to use the iostream abstraction. However this fake connection would get destroyed if the listening end deleted it's socket. This commit introduces a wrapper around sockaddr_un and the client fd and uses sendto instead of write.
tobim
force-pushed
the
story/ch24267/reconnect-uds-dgram-metrics
branch
from
49d8957 to
87649a3
Compare
dominiklohmann
requested changes
Jun 1, 2021
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
- Make it explicit that it is a move only structure - Remove the socket from the filesystem immediately after bind, it isn't required any more. - Create the filesystem path for the sending socket in a temporary directory instead of next to the destination.
dominiklohmann
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous way of setting up the UDS datagram metrics relied on a fake connection that made it possible to use the iostream abstraction. However this fake connection would get destroyed if the listening end deleted it's socket.
This commit introduces a wrapper around sockaddr_un and the client fd and uses sendto instead of write.
📔 Description
📝 Checklist
🎯 Review Instructions
Code review by file.
Test by running VAST with
And run and restart
socat UNIX-RECV:/tmp/vast-metrics.sockwhile the VAST node is running.