Fixup repository-internal symlinks in Dockerfile #1705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch25708/pcap-plugin-docker
branch
from
48053c8 to
17853fb
Compare
Before this change it was impossible to build the PCAP plugin inside the Docker image. Docker does not resolve symlinks when copying, not even those that are internal to the repository.
dominiklohmann
force-pushed
the
story/ch25708/pcap-plugin-docker
branch
from
17853fb to
287346a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
Before this change it was impossible to build the PCAP plugin inside the Docker image. Docker does not resolve symlinks when copying, not even those that are internal to the repository.
📝 Checklist
🎯 Review Instructions
See if CI runs through, basically. Also, read the changed Dockerfile.