Handle quoted strings in CSV parser #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch12199/quoted-strings-in-csv-parser
branch
from
90b9059 to
fc21157
Compare
lava
reviewed
Jun 8, 2021
This change makes it possible to import CSV data containing quoted strings that contain the configured separator. This works for both header and fields.
dominiklohmann
force-pushed
the
story/ch12199/quoted-strings-in-csv-parser
branch
from
fc21157 to
9ec1f35
Compare
lava
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This change makes it possible to import CSV data containing quoted strings that contain the configured separator. This works for both header and fields.
📝 Checklist
🎯 Review Instructions
Read code diff. Check provided unit tests.