Fix shutdown hang in sources on SIGTERM/SIGINT #1718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The new TRANSFORMER actor that always resides in the import process must be shut down when the SOURCE shuts down, as the SOURCE is the sole owner of the TRANSFORMER. Before this change, the DATAGRAM SOURCE shut down the stream of the TRANSFORMER, which caused it to quit somehow, but the SOURCE didn't propagate the shutdown to the TRANSFORMER at all, causing the import process to hang until a repeated SIGTERM/SIGINT led to a hard kill.
📝 Checklist
🎯 Review Instructions
Try locally.