Fix duplication of lists in client command options #1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
topic/fix-duplicated-local-options-bug
branch
2 times, most recently
from
bf14b28 to
ee7dfd9
Compare
We've recently changed VAST to merge lists in its configuration from all possible sources rather than overwriting them. However, in the command-executing `run` function we merged configuration options with the local actor system's options again in case the command invocation happened remotely, which was no longer a no-op now that we merge lists, which in turn led to all list options of client commands being duplicated. This fixes the issue by not merging lists between client and server when doing so.
dominiklohmann
force-pushed
the
topic/fix-duplicated-local-options-bug
branch
from
ee7dfd9 to
944c922
Compare
lava
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
We've recently changed VAST to merge lists in its configuration from all possible sources rather than overwriting them. However, in the command-executing
runfunction we merged configuration options with the local actor system's options again in case the command invocation happened remotely, which was no longer a no-op now that we merge lists, which in turn led to all list options of client commands being duplicated. This fixes the issue by not merging lists between client and server when doing so.📝 Checklist
🎯 Review Instructions
Test locally. E.g., view merged options by running with
--verbosity=trace.