Print the import transformer status #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
story/ch26790/congested
branch
2 times, most recently
from
6c57137 to
cffbee1
Compare
|
This turned into a bit of a refactoring of the status handlers now. I originally hoped to manage this with less code, but at least it should now be easier to write handlers that retrieve additional data from child components. |
dominiklohmann
approved these changes
Jul 9, 2021
tobim
force-pushed
the
story/ch26790/congested
branch
from
31bcf07 to
8d62d41
Compare
|
Rebased on top of 84140ff now. |
tobim
force-pushed
the
story/ch26790/congested
branch
from
8d62d41 to
b2f0e26
Compare
tobim
force-pushed
the
story/ch26790/congested
branch
from
b2f0e26 to
b4c9e51
Compare
This file will receive additional functionality in the next commit. This commit contains the mechanical preparation.
In some cases we need to calculate a reduced timeout so nested requests that that can't be handled fast enough don't cause the failure to bubble up to the root requester. A concrete example is the status request: the nested handlers can't wait the same amount as the ones in the layers above, because the outer requests are sent earlier. For example in the index, if a single partition fails to respond, we need to stop waiting earlier and send back the rest of the data, otherwise the entire "index" section would be missing from the output of `vast status`. Changing the type of the default value give us more headroom for those calculations without requiring extra casting of temporaries.
Many of our status message handlers have lot's of boilerplate to forward the requests to children and insert the collected subsection into a unified response. The tooling introduced here aims to reduce code duplication and abstract the response lifetime management out of the status handlers.
This changes the convenience overload of collect_status to take a `std::string_view` instead of a const char*. The general overload had to be restricted to only work with callables in the type signature to enable this, because it would otherwise be preferred over the conversion to `std::string_view`.
The previous change to the status handler in the node resulted in redundant sections for the top level components. This change aligns the insertion for the subcomponents with the ones that are nested at deeper levels.
tobim
force-pushed
the
story/ch26790/congested
branch
from
79f8fb8 to
dc8c10d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
We didn't request a status message from the import transformer so far. This fixes that oversight.