Skip to content

Fix bug in bitmap offset computation #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2021
Merged

Fix bug in bitmap offset computation #1755

merged 4 commits into from
Jul 8, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jul 2, 2021 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jul 5, 2021
@lava lava force-pushed the story/ch26902 branch from 0d3f865 to 264161f Compare July 6, 2021 10:54
@lava lava marked this pull request as ready for review July 6, 2021 10:59
@lava lava force-pushed the story/ch26902 branch 2 times, most recently from 8d78551 to badc738 Compare July 6, 2021 11:44
@lava lava force-pushed the story/ch26902 branch from badc738 to 0963cd8 Compare July 6, 2021 11:52
tobim
tobim reviewed Jul 6, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fix is correct, but I'm not sure whether there is another problem hiding in that function. Question below.

tobim
tobim approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work getting to the bottom of this!

@lava lava merged commit be3f891 into master Jul 8, 2021
@lava lava deleted the story/ch26902 branch July 8, 2021 09:57
@lava lava mentioned this pull request Jul 8, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lava @mavam @tobim @dominiklohmann