-
-
Notifications
You must be signed in to change notification settings - Fork 97
Add Zeek Broker reader plugin #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c4d96b
to
2adcc47
Compare
Because Broker also starts at the same type ID as VAST, we face clashes when trying to use both in the same application. Hence we move the starting type ID for VAST further down.
We can now parse Zeek's LogCreate messages and derive a VAST type from them.
2adcc47
to
3493f19
Compare
dominiklohmann
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just have some smaller things, plus this needs CI to run through. Let's get this in and then test this in our E2E setup outside of this repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR adds a new
broker
reader plugin, enabling VAST to be true nativeLogger node. This approach takes a slightly different path than the usual way
of writing a Zeek plugin and implementing one's own
WriterBackend
. Here arethe pros and cons of this method.
Pros:
remotely
parsing/repacking the data again to ship it to VAST
Cons:
Since filtering can also be implemented easily downstream in VAST, we find that
the pros dominate this method.
📝 Checklist
poll
withget(num, timeout)
🎯 Review Instructions
File-by-file.