Skip to content

Add disk-monitor support for partition-local stores #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 12, 2021
Merged

Add disk-monitor support for partition-local stores #1762

merged 4 commits into from
Jul 12, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jul 8, 2021

  • Add new 'lru_cache::eject()' member function
  • Implement disk monitor support for local stores

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review commits individually.

lava added 2 commits July 8, 2021 12:05
@lava
Add new 'lru_cache::eject()' member function
ad88074
@lava
Implement disk monitor support for local stores
c04c681 
This reorganizes the semantics of `atom::erase` so that now
the partition is responsible for erasing its events from
the store. This means that the disk monitor no longer has a
dependency on the global archive, and arbitrary store backends
are supported.
@lava lava force-pushed the story/ch26807/disk-monitor-store-plugin branch from 6de2e3a to c04c681 Compare July 8, 2021 10:05
dominiklohmann
dominiklohmann reviewed Jul 8, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I only looked at the code so far, will give this a spin later today. Some early comments for now.

@dominiklohmann dominiklohmann added the feature New functionality label Jul 9, 2021
dominiklohmann
dominiklohmann approved these changes Jul 9, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran this locally for a few hours and things seem to work as expected. Please adjust the old changelog entry before merging.

@lava lava enabled auto-merge July 12, 2021 06:58
@lava lava merged commit 81f9182 into master Jul 12, 2021
@lava lava deleted the story/ch26807/disk-monitor-store-plugin branch July 12, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @dominiklohmann