Skip to content

Disable auto-vectorization in prebuilt Docker images #1778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jul 15, 2021

📔 Description

The following new build options exist:

  • VAST_ENABLE_AUTO_VECTORIZATION enables/disables all auto-vectorization flags.
  • VAST_ENABLE_SSE_INSTRUCTIONS enables -msse; similar options exist for SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AVX, and AVX2.

The CI now builds the Docker images hosted on Dockerhub with auto-vectorization disabled. This increases the portability of our hosted Docker images. Users building locally will still have flags enabled that their respective device supports.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

  • @tenzir/backend read the CMake code carefully
  • @rolandpeelen see if this fixes the issue with AVX2 instructions on your end

The following new build options exist:
- `VAST_ENABLE_AUTO_VECTORIZATION` enables/disables all
  auto-vectorization flags.
- `VAST_ENABLE_SSE_INSTRUCTIONS` enables `-msse`; similar options exist
  for SSE2, SSE3, SSSE3, SSE4.1, SSE4.2, AVX, and AVX2.
This increases the portability of our hosted Docker images. Users
building locally will still have flags enabled that their respective
device supports.
@lava
Copy link
Member

lava commented Jul 16, 2021

Did you do any testing on how this impacts performance?

Also, from the description it sounds like only AVX2 support was problematic, so would it make more sense to only turn that off? From a brief glance at Wikipedia, it sounds like all the other features should be supported by basically every CPU made in the last 10 years?

@dominiklohmann
Copy link
Member Author

dominiklohmann commented Jul 16, 2021

Did you do any testing on how this impacts performance?

I did not. It's only disabled for Docker, which we don't use in high-perf scenarios.

Also, from the description it sounds like only AVX2 support was problematic, so would it make more sense to only turn that off?

We can do that as well, will make that change.

@dominiklohmann dominiklohmann force-pushed the topic/disable-sse-flags-in-docker-image branch from 12a3cc3 to b270f69 Compare July 16, 2021 09:31
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good; would still be interesting to know the performance impact so we can display a note somewhere if required, but given that Roland is affected we'd probably merge this anyways even if the impact was high.

@dominiklohmann
Copy link
Member Author

would still be interesting to know the performance impact

None since the last release definitely, because we only added the AVX stuff a week ago.

@dominiklohmann dominiklohmann force-pushed the topic/disable-sse-flags-in-docker-image branch from b270f69 to fbe3e27 Compare July 16, 2021 09:35
@dominiklohmann dominiklohmann force-pushed the topic/disable-sse-flags-in-docker-image branch from fbe3e27 to 60b5411 Compare July 16, 2021 09:35
@dominiklohmann dominiklohmann enabled auto-merge July 16, 2021 09:40
@dominiklohmann dominiklohmann merged commit ca012fd into master Jul 16, 2021
@dominiklohmann dominiklohmann deleted the topic/disable-sse-flags-in-docker-image branch July 16, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants