Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate VAST_ENABLE_JOURNALD_LOGGING setting to config header #1780

Merged
merged 3 commits into from
Jul 16, 2021
Merged

Propagate VAST_ENABLE_JOURNALD_LOGGING setting to config header #1780

merged 3 commits into from
Jul 16, 2021

Conversation

lava
Copy link
Member

@lava lava commented Jul 16, 2021

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava force-pushed the topic/journald-sink branch from ec1decd to 8379d30 Compare July 16, 2021 10:54
@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jul 16, 2021
@lava @mavam
Apply review comments
56be27c 
Co-authored-by: Matthias Vallentin <matthias@tenzir.com>
@lava lava enabled auto-merge July 16, 2021 12:44
@lava lava merged commit 33485b1 into master Jul 16, 2021
@lava lava deleted the topic/journald-sink branch July 16, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam left review comments

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @mavam @dominiklohmann