Interpret metrics paths relative to the db root #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paths `vast.metrics.{file,uds}-sink.path` were, unlike othe relative
paths, interpreted as relative to the current working directory of the
VAST server instead of relative to the database directory. This changes
the ACCOUNTANT actor to be aware of the database directory.
dominiklohmann
force-pushed
the
story/ch27391/relative-metrics-paths
branch
from
60d4dab to
594279c
Compare
tobim
requested changes
Aug 17, 2021
tobim
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The paths
vast.metrics.{file,uds}-sink.pathwere, unlike othe relative paths, interpreted as relative to the current working directory of the VAST server instead of relative to the database directory. This changes the ACCOUNTANT actor to be aware of the database directory.📝 Checklist
🎯 Review Instructions
File-by-file. Run locally.