Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging in systemd when built without support #1857

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

tobim
Copy link
Member

@tobim tobim commented Aug 20, 2021

📔 Description

VAST now only switches to journald style logging by default when it is actually supported.

📝 Checklist

  • All user-facing changes have changelog entries.

VAST now only switches to journald style logging by default when
it is actually supported.
@tobim tobim added the bug Incorrect behavior label Aug 20, 2021
@tobim tobim requested a review from lava August 20, 2021 07:31
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dominiklohmann
Copy link
Member

Please correct the comment in the vast.yaml.example as well and comment out the default value.

@tobim tobim merged commit 5de256d into master Aug 20, 2021
@tobim tobim deleted the topic/journald-static-off branch August 20, 2021 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants