Add tool to regenerate .mdx files #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
topic/midx-regenerate
branch
from
e6b3004 to
5cac181
Compare
lava
force-pushed
the
topic/midx-regenerate
branch
from
36cd8f3 to
577670c
Compare
lava
force-pushed
the
topic/midx-regenerate
branch
from
577670c to
06fd867
Compare
lava
force-pushed
the
topic/midx-regenerate
branch
from
06fd867 to
ca5b7e7
Compare
dominiklohmann
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Just some smaller comments on the README.
The tool itself seems to work as expected. I tested this by using an older version of VAST to create a database, and then using this tool on the database before running a recent version of VAST. Everything started up as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
On a large DB, it can take a lot of time to regenerate the .mdx synopsis files on startup if the previous version somehow got corrupted or outdated. VAST never accesses these files during operation, so this can safely be done before restarting VAST to ensure minimal downtime. This tool provides just that functionality, ie. a way to bulk-update all
.mdxfiles of a database that does not interfere with the running VAST process.📝 Checklist
🎯 Review Instructions