Skip to content

Show loaded config files in status output #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2021
Merged

Show loaded config files in status output #1871

merged 2 commits into from
Aug 30, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

This makes vast status --detailed show the loaded config files in the server process.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Build locally, run vast status --detailed | jq .system to see.

@dominiklohmann dominiklohmann added the feature New functionality label Aug 30, 2021
@dominiklohmann dominiklohmann requested a review from a team August 30, 2021 08:45
@dominiklohmann dominiklohmann force-pushed the story/ch28073/loaded-config-files-status branch from 8a4a779 to 9a8d272 Compare August 30, 2021 08:46
mavam
mavam approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to avoid get/set prefixes. Approval modulo this change.

@dominiklohmann dominiklohmann merged commit ee7cf18 into master Aug 30, 2021
@dominiklohmann dominiklohmann deleted the story/ch28073/loaded-config-files-status branch August 30, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam