Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make partition-local stores the default #1876

Merged
merged 4 commits into from
Sep 13, 2021

Conversation

lava
Copy link
Member

@lava lava commented Sep 8, 2021

📔 Description

Make partition-local stores the default

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

@lava lava force-pushed the story/ch26809/local-stores-default branch from fc0ea65 to c37742f Compare September 8, 2021 08:11
Since the evaluator does not send the delta to the
client anymore, there is also no need to explicitly
compute it to check if its non-zero.
Since 'lsvast' currently does not print information for partition-local
stores, the output of the unit test becomes slightly shorter.
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using this locally for a while now, so if the tests pass with the changes this is all good to me.

@lava lava merged commit f3234d1 into master Sep 13, 2021
@lava lava deleted the story/ch26809/local-stores-default branch September 13, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants