-
-
Notifications
You must be signed in to change notification settings - Fork 96
Let empty queries export everything #1879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let empty queries export everything #1879
Conversation
2631b2f
to
0a597b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you modify the expression parser for this? If the calling context provides the empty string, you can still fill in the somewhat arbitrary expression.
|
0a597b4
to
c68ede4
Compare
This changes the empty query, i.e., a non-provided query argument, to export everything. Under the hood this is implemented by transforming empty queries into a query that parses everything, namely `#type != "this expression matches everything"`.
c68ede4
to
c628c56
Compare
Noticed that we still used `caf::deep_to_string` in queries in log messages, which really doesn't make sense in user-facing log messages like "index delays <query> because it is still starting up"; These now render much more nicely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks simple enough, and I've tested locally that it works as expected.
It does a bit more than what was discussed in the story; we may want to reconsider if we want to restrict this feature to export
since for expose and pivot it is a bit unintuitive, and for vast count
a user may expect a more performant implementation for the operation of counting the number of items in the database.
ecb9f3a
to
a3b91d3
Compare
Doing this for pivot and explore doesn't really make sense, as that'd just return everything without any newly added context.
a3b91d3
to
76944e1
Compare
📔 Description
This changes the empty query, i.e., either a non-provided query argument or an empty string as the query argument, to export everything. Under the hood this is implemented by transforming empty queries into a query that parses everything, namely
#type != "this expression matches everything"
.📝 Checklist
🎯 Review Instructions
Try it out.