Skip to content

Tailor expressions in filter operation #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

dominiklohmann
Copy link
Member

📔 Description

We ran into a vast::die call due to an unresolved field extractor when using the filter function with a field extractor. This most notably caused import filter like event_type == "alert" to fail.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit.

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Sep 21, 2021
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good, but from the description it sounds like we can very easily add the problematic query as a new test.

@dominiklohmann dominiklohmann force-pushed the story/ch27450/segfault-in-filter branch from 047483f to 998b6c2 Compare September 21, 2021 10:18
@dominiklohmann dominiklohmann requested a review from lava September 21, 2021 10:19
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding the test!

@dominiklohmann dominiklohmann merged commit 0e23c1f into master Sep 21, 2021
@dominiklohmann dominiklohmann deleted the story/ch27450/segfault-in-filter branch September 21, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants