Disallow unsupported field meta extractor predicates #1886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
story/ch28414/no-field-patterns
branch
from
038f3e2 to
255b58d
Compare
The field meta extractor currently only supports equality comparisons with strings. This change adds a validation check to abort with an error in all other cases.
tobim
force-pushed
the
story/ch28414/no-field-patterns
branch
from
255b58d to
1c8d17d
Compare
tobim
force-pushed
the
story/ch28414/no-field-patterns
branch
from
1c8d17d to
2298f83
Compare
dominiklohmann
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
The field meta extractor currently only supports equality comparisons with strings. This change adds a validation check to abort with an error in all other cases.
📝 Checklist
🎯 Review Instructions
Read the commits in reverse order; consider whether additional cases should be tested.