Skip to content

Partition transforms #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 25, 2021
Merged

Partition transforms #1887

merged 13 commits into from
Oct 25, 2021

Conversation

lava
Copy link
Member

@lava lava commented Sep 22, 2021 •
edited
Loading

📔 Description

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review commit-by-commit.

@dominiklohmann dominiklohmann added the feature New functionality label Sep 23, 2021
@lava lava force-pushed the story/ch25330/partition-transforms branch 3 times, most recently from d61aecc to d121e14 Compare October 7, 2021 19:39
@lava lava marked this pull request as ready for review October 7, 2021 21:41
@lava lava changed the title WIP: Partition transforms Partition transforms Oct 7, 2021
@lava lava force-pushed the story/ch25330/partition-transforms branch 2 times, most recently from abaf48e to d4fc920 Compare October 8, 2021 08:58
lava
lava commented Oct 8, 2021
View reviewed changes
dominiklohmann
dominiklohmann reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a peek.

dominiklohmann
dominiklohmann reviewed Oct 12, 2021
View reviewed changes
@lava lava force-pushed the story/ch25330/partition-transforms branch from d4fc920 to f24e949 Compare October 13, 2021 17:21
tobim
tobim reviewed Oct 19, 2021
View reviewed changes
@lava lava force-pushed the story/ch25330/partition-transforms branch from 2f071a3 to 2380e96 Compare October 22, 2021 17:15
lava added 8 commits October 22, 2021 20:53
@lava
Add unit tests for partition transforms
76ae58d
@lava
Add a CHANGELOG entry
f4e1f1d
@lava
Incorporate review feedback
f6243a0
@lava
Use correct caf version
47ac7f8
@lava
Fixup naming in test
abf44e1
@lava
Write transformed partitions to the correct location
a10894e 
This fixes a bug where transformed partitions where saved
to the wrong disk location.
@lava
Use the filesystem actor to erase partition synopsis
8f2200b 
Due to the use of relative paths, synopses were not
correctly removed when the current directory of VAST
was different from the database directory.
@lava
Fix warnings and rename importer actor handles
9ae6e2b
@lava lava force-pushed the story/ch25330/partition-transforms branch from 6233c30 to 9ae6e2b Compare October 22, 2021 18:54
tobim
tobim approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the final change requests this is looking great!

@lava lava force-pushed the story/ch25330/partition-transforms branch from 093da3c to dad8dfa Compare October 25, 2021 17:14
@lava lava merged commit 4859bc5 into master Oct 25, 2021
@lava lava deleted the story/ch25330/partition-transforms branch October 25, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann left review comments

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @tobim @dominiklohmann