Skip to content

Bump minimum required CMake version to 3.18 #1914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2021
Merged

Bump minimum required CMake version to 3.18 #1914

merged 4 commits into from
Oct 20, 2021

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Oct 20, 2021 •
edited
Loading

📔 Description

This is what current Debian stable (Bullseye) offers, so let's make use of it.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Commit-by-commit. I've verified that all instances of cmake_minimum_required were adapted.

@dominiklohmann
Bump minimum required CMake version to 3.18
e1b3d0c 
This is what current Debian stable (Bullseye) offers, so let's make use
of it.
@dominiklohmann
Disable precompiled headers on ARM Macs
d0c0327 
This works around a very noisy warning that is produced for every
translation unit that links against libvast or is part of libvast.
@dominiklohmann dominiklohmann added the maintenance Tasks for keeping up the infrastructure label Oct 20, 2021
@dominiklohmann dominiklohmann requested a review from a team October 20, 2021 07:59
tobim
tobim reviewed Oct 20, 2021
View reviewed changes
@dominiklohmann dominiklohmann requested a review from tobim October 20, 2021 08:07
tobim
tobim approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a trivial change that doesn't need to be tested outside of CI.

@dominiklohmann dominiklohmann merged commit 1fc7509 into master Oct 20, 2021
@dominiklohmann dominiklohmann deleted the story/ch29096/cmake-3.18 branch October 20, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobim tobim tobim approved these changes

Assignees
No one assigned
Labels
maintenance Tasks for keeping up the infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @tobim