Skip to content

Implement a selection transform plugin #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 3, 2022
Merged

Implement a selection transform plugin #2014

merged 2 commits into from
Jan 3, 2022

Conversation

6yozo
Copy link
Contributor

@6yozo 6yozo commented Dec 16, 2021 •
edited
Loading

Create the new selection transform plugin.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request file-by-file.

@6yozo 6yozo self-assigned this Dec 16, 2021
@6yozo 6yozo marked this pull request as draft December 16, 2021 18:15
@6yozo 6yozo force-pushed the story/sc-29695/select branch from 1c415b4 to 00cf0e7 Compare December 16, 2021 18:24
dominiklohmann
dominiklohmann reviewed Dec 17, 2021
View reviewed changes
@6yozo 6yozo force-pushed the story/sc-29695/select branch 3 times, most recently from bcdf689 to 3f17261 Compare December 17, 2021 17:25
6yozo
6yozo commented Dec 17, 2021
View reviewed changes
@6yozo 6yozo marked this pull request as ready for review December 17, 2021 18:15
@6yozo 6yozo requested a review from lava December 17, 2021 18:16
lava
lava approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this looks very close already.

I'm approving now and left comments for the FIXME's, so you can resolve them as you go and then merge for yourself afterwards.

@6yozo 6yozo force-pushed the story/sc-29695/select branch 2 times, most recently from b8d587a to c3ae093 Compare December 31, 2021 09:17
@6yozo 6yozo force-pushed the story/sc-29695/select branch from c3ae093 to 126eb6a Compare January 3, 2022 01:04
@lava lava merged commit ce57c39 into master Jan 3, 2022
@lava lava deleted the story/sc-29695/select branch January 3, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann left review comments

@lava lava lava approved these changes

Assignees

@6yozo 6yozo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@6yozo @lava @dominiklohmann