Skip to content

Start the telemetry loop of the index correctly #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jan 14, 2022

If I understood the code before this change directly, then the index set the accountant actor properly upon spawning, and then expected to be sent the accountant actor again to start its telemetry loop—which never happens. This resulted in the telemetry loop never actually being started.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

The change itself is trivial.

I requested @tobim for review because he worked on these metrics recently, and I know that they've been shown on our testbed. When did this break?

@dominiklohmann dominiklohmann added the bug Incorrect behavior label Jan 14, 2022
@dominiklohmann dominiklohmann requested a review from tobim January 14, 2022 09:36
If I understood the code before this change directly, then the index set the
accountant actor properly upon spawning, and then expected to be sent the
accountant actor again to start its telemetry loop—which never happens. This
resulted in the telemetry loop never actually being started.
@dominiklohmann dominiklohmann force-pushed the topic/fix-index-metrics branch from bbdade9 to a4eb0d4 Compare January 14, 2022 09:37
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me, if I remember correctly the accountant used to be passed as a message everywhere, so I assume this was forgotten during some refactoring.

@dominiklohmann
Copy link
Member Author

if I remember correctly the accountant used to be passed as a message everywhere, so I assume this was forgotten during some refactoring.

This is now only the case for the importer and the legacy archive, all the remaining actors get the handle passed alongside the call to spawn. For the index it looks like this was only done partially.

@dominiklohmann dominiklohmann merged commit c554927 into master Jan 14, 2022
@dominiklohmann dominiklohmann deleted the topic/fix-index-metrics branch January 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants