Create intermediate dirs for db-directory and respect schema-dirs in bare mode #2046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `vast --bare-mode --schema-dirs=... <command>` wrongly caused the schema dirs to not be read at all.
Before this change, running `vast --db-directory=/a/b/c` failed if `/a` or `/a/b` did not exist and only tried to create the subdirectory `c`. VAST now properly creates all intermediate directories as required.
dispanser
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a two-fold fix that came up when reviewing a potential bug with @satta—thanks for the feedback!
📝 Checklist
🎯 Review Instructions
Commit-by-commit.