-
-
Notifications
You must be signed in to change notification settings - Fork 99
VAST changes for spatial compaction #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is the deep copy of the partition synopsis, I don't understand why this is necessary.
b70f5d2
to
dca7832
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the high-level semantics that are implemented here.
dca7832
to
dc156ec
Compare
I want f6fc28a in my topic branch. Should I cherry-pick or is this one going to merged soon? EDIT: looks like auto-merge is on, so only a CI thingy left. |
I think this just needs to be adapted to FlatBuffers naming changes on master :) |
dc156ec
to
c804df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some minor stuff that should be fixed before merging.
c804df4
to
548f0d5
Compare
This contains 4 independent changes that are required by the compaction plugin.
📝 Checklist
🎯 Review Instructions
Review this pull request commit-by-commit.