Skip to content

VAST changes for spatial compaction #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 8, 2022
Merged

VAST changes for spatial compaction #2064

merged 11 commits into from
Feb 8, 2022

Conversation

lava
Copy link
Member

@lava lava commented Feb 3, 2022

This contains 4 independent changes that are required by the compaction plugin.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request commit-by-commit.

Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern is the deep copy of the partition synopsis, I don't understand why this is necessary.

@lava lava force-pushed the topic/spatial-compaction branch 3 times, most recently from b70f5d2 to dca7832 Compare February 8, 2022 11:01
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the high-level semantics that are implemented here.

@lava lava force-pushed the topic/spatial-compaction branch from dca7832 to dc156ec Compare February 8, 2022 11:56
@lava lava enabled auto-merge February 8, 2022 11:56
@mavam
Copy link
Member

mavam commented Feb 8, 2022

I want f6fc28a in my topic branch. Should I cherry-pick or is this one going to merged soon?

EDIT: looks like auto-merge is on, so only a CI thingy left.

@dominiklohmann
Copy link
Member

I think this just needs to be adapted to FlatBuffers naming changes on master :)

@lava lava force-pushed the topic/spatial-compaction branch from dc156ec to c804df4 Compare February 8, 2022 13:23
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor stuff that should be fixed before merging.

@lava lava force-pushed the topic/spatial-compaction branch from c804df4 to 548f0d5 Compare February 8, 2022 14:02
@lava lava merged commit 873483f into master Feb 8, 2022
@lava lava deleted the topic/spatial-compaction branch February 8, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants