Skip to content

Projection transform step should not skip slices where no columns are matched #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2022
Merged

Projection transform step should not skip slices where no columns are matched #2082

merged 2 commits into from
Feb 14, 2022

Conversation

6yozo
Copy link
Contributor

@6yozo 6yozo commented Feb 14, 2022

Skip slices when no columns are matched in projection

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request file-by-file.

@6yozo 6yozo added the bug Incorrect behavior label Feb 14, 2022
@6yozo 6yozo requested a review from a team February 14, 2022 11:14
dominiklohmann
dominiklohmann approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine; just needs a changelog entry.

@6yozo 6yozo force-pushed the story/sc-31128/projection-with-no-columns branch from 1c853b7 to ac53c4f Compare February 14, 2022 12:30
@6yozo 6yozo merged commit 729adb5 into master Feb 14, 2022
@6yozo 6yozo deleted the story/sc-31128/projection-with-no-columns branch February 14, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@6yozo @dominiklohmann