Correctly terminate the explore command #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mavam
reviewed
Feb 28, 2022
This commit fixes 2 issues that prevented the exporter for the initial query from exiting. When the explorer received the requested number of results for the initial query it did not communicate this to the exporter, causing the latter to wait for a follow-up request indefinitely. When the `max-events-query * max-events-context` was lower than `max-events` the sink would wait for additional results but the `explorer` would only wait to get terminated.
tobim
force-pushed
the
topic/fix-explorer-shutdown
branch
from
0a29187 to
e558403
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes 2 issues that prevented the exporter for the initial query from exiting.
max-events-query * max-events-contextwas lower thanmax-eventsthe sink would wait for additional results but theexplorerwould only wait to get terminated.📝 Checklist
🎯 Review Instructions
Run an explore command on a database with more than 5 partitions and an initial query with a low selectivity.