Skip to content

Add a grand total event counter to the status output #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

6yozo
Copy link
Contributor

@6yozo 6yozo commented Mar 3, 2022

Add a grand total event counter to the status output

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request file-by-file.

@dominiklohmann dominiklohmann added the feature New functionality label Mar 3, 2022
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remarks:

  • The first two commits in this look unrelated to me.
  • There's an integration test that needs an adjustment.
  • Right now there's an ambiguity if there's a schema named total, which I think we can avoid by putting the sum in the outer statistics object.

@6yozo 6yozo force-pushed the story/sc-31465/status-grand-total branch from 5552800 to 802d3bf Compare March 4, 2022 04:19
Copy link
Member

@tobim tobim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should emit this info for vast status without --detailed too.

@6yozo 6yozo requested a review from tobim March 10, 2022 08:03
@6yozo 6yozo force-pushed the story/sc-31465/status-grand-total branch from 1907896 to e21f3cf Compare March 11, 2022 08:34
@6yozo 6yozo merged commit bc44773 into master Mar 11, 2022
@6yozo 6yozo deleted the story/sc-31465/status-grand-total branch March 11, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants