Fix race condition with exporter timeouts #2165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
topic/hanging-exporter
branch
from
5586dc5 to
57cf9ad
Compare
A query gets removed from the list of 'pending' queries in the index when the corresponding exporter actor goes DOWN. However, when the meta index lookup takes long enough the exporter can time out before the query is added to 'pending'. We did not check for this condition and thus would add an already-dead query to 'pending', which of course would never be able to progress afterwards.
lava
force-pushed
the
topic/hanging-exporter
branch
from
57cf9ad to
cf9c5d5
Compare
lava
commented
Mar 28, 2022
Pass the original sender to the 'atom::internal' continuation handler in the index, to be able to robustly check for exited senders also for queries that were scheduled through the backlog.
lava
force-pushed
the
topic/hanging-exporter
branch
from
3875591 to
c84cb6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
🎯 Review Instructions