Skip to content

Fix race condition with exporter timeouts #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2022
Merged

Fix race condition with exporter timeouts #2167

merged 3 commits into from
Mar 30, 2022

Conversation

lava
Copy link
Member

@lava lava commented Mar 28, 2022 •
edited
Loading

This is a forward-port of a recent bugfix on the v1.1.x branch.

  • Add missing space in log message
  • Fix race condition on timeout of query actor
  • Make race condition fix more robust

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava force-pushed the story/sc-32496/exporter-hang branch 2 times, most recently from 53e33fc to 367f465 Compare March 28, 2022 14:36
lava added 3 commits March 28, 2022 16:37
@lava
Add missing space in log message
d99ba59
@lava
Add a 'sender' argument to an internal index handler to fix a race
bd3fbab 
A query gets removed from the list of 'pending' queries
in the index when the corresponding exporter actor goes
DOWN.

However, when the meta index lookup takes long enough the
exporter can time out before the query is added to 'pending'.
We did not check for this condition and thus would add
an already-dead query to 'pending', which of course would
never be able to progress afterwards.
@lava
Add changelog entry
c59f9f3
@lava lava force-pushed the story/sc-32496/exporter-hang branch from 367f465 to c59f9f3 Compare March 28, 2022 14:37
dispanser
dispanser approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@dispanser dispanser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a backport of #2165, with very minimal adaptions.

@lava lava added the bug Incorrect behavior label Mar 29, 2022
@lava lava merged commit 2fbce9e into master Mar 30, 2022
@lava lava deleted the story/sc-32496/exporter-hang branch March 30, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dispanser dispanser dispanser approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @dispanser