Skip to content

Reduce the default log queue size for client commands #2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

tobim
Copy link
Member

@tobim tobim commented Mar 31, 2022

The previous default of 1'000'000 lead to about 400MB of additional memory consumption. This is acceptable for the server but not for the often short-running client commands.

This PR also exposes the --log-queue-size option on the command line.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.

tobim added 2 commits March 31, 2022 10:01
The previous default of 1'000'000 lead to about 400MB of additional
memory consumption. This is acceptable for the server but not for
the often short-running client commands.
@tobim tobim requested a review from a team March 31, 2022 08:47
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@tobim tobim enabled auto-merge March 31, 2022 09:04
@tobim tobim merged commit 751da32 into master Mar 31, 2022
@tobim tobim deleted the story/sc-32547/tune-log-queue-size branch March 31, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants