Implement support for transforms that apply to every type and use compaction for aging #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
topic/aging-with-compaction
branch
from
c711591 to
b7a6700
Compare
lava
force-pushed
the
topic/aging-with-compaction
branch
from
b7a6700 to
7f28c57
Compare
There was a problem hiding this comment.
This is great, and thanks especially for turning the eraser into a typed actor.
I think this is almost ready to go. We need to undeprecate aging and also mark it as no longer experimental, and the rest should be covered by the remaining TODO comments and the few comments I left on the PR, which are mostly of stylistic nature.
dominiklohmann
approved these changes
Apr 6, 2022
lava
force-pushed
the
topic/aging-with-compaction
branch
2 times, most recently
from
dc56c08 to
3f5c51c
Compare
This was only used by the eraser, which has been updated to use compaction instead.
dominiklohmann
force-pushed
the
topic/aging-with-compaction
branch
from
3af0b60 to
b8c0692
Compare
dispanser
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
I verified the last four commits done by @dominiklohmann . We talked about those earlier.
dominiklohmann
force-pushed
the
topic/aging-with-compaction
branch
from
dfa9aaf to
57b3e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aging used to work only partially; deleting events from the archive but not from the index. It was deprecated and scheduled for removal in VAST 2.0.
With this PR we change the internals of the eraser, so aging now works as a functionality-reduced form of temporal compaction.
Some supporting commits add support for transforms that apply to every type, and a new "invert" option for the "select" transform step.
📝 Checklist
🎯 Review Instructions