Skip to content

Don't send null pointers when erasing whole partitions #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 19, 2022
Merged

Don't send null pointers when erasing whole partitions #2227

merged 6 commits into from
Apr 19, 2022

Conversation

lava
Copy link
Member

@lava lava commented Apr 19, 2022 •
edited
Loading

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request as a whole.

@lava lava added the bug Incorrect behavior label Apr 19, 2022
dominiklohmann
dominiklohmann approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs a changelog entry because the bug has actually existed for a while now. Other than that the fix looks correct to me.

@lava lava enabled auto-merge April 19, 2022 16:02
@lava lava merged commit 6d9cd9d into master Apr 19, 2022
@lava lava deleted the topic/transformer-persist-logic branch April 19, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
bug Incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lava @dominiklohmann @tobim