Skip to content

Clean up transform steps (and native plugins generally) #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 20, 2022

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Apr 20, 2022

This follows up on an internal discussion to rename some transform step before the upcoming major release of VAST v2.0 to align their names with what we generally deemed most suitable.

Here's a summary of the changes:

  • The rename step can now rename fields as well as schemas.
  • The where step supersedes both the filter and select steps.
  • The delete step is now called drop.
  • The project step is now called put.
  • The replace step now supports all complex types that can be inferred.
  • The aggregate step is now called summarize.

And lastly, developer-facing only:

  • Native plugins no longer need to be explicitly registered in the CMakeLists.txt file of libvast.
  • It is now harder to misuse native plugins code by calling it directly from libvast; instead, calls must now go through the plugin API. This supersedes Simplify native plugins setup #2220.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review the description. Then read the code commit-by-commit.

Before merging this still needs a documentation update.

@dominiklohmann dominiklohmann added refactoring Restructuring of existing code bug Incorrect behavior labels Apr 20, 2022
@dominiklohmann dominiklohmann force-pushed the story/sc-32738/rename-transform-steps branch from 10beb48 to 07f4b21 Compare April 20, 2022 12:47
@dominiklohmann dominiklohmann marked this pull request as ready for review April 20, 2022 12:54
@dominiklohmann dominiklohmann requested a review from mavam April 20, 2022 12:55
@dominiklohmann dominiklohmann force-pushed the story/sc-32738/rename-transform-steps branch from 2f0628c to 4d0438f Compare April 20, 2022 13:03
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! CI will sanity-check this.

I have some small cosmetic comments only.

@dominiklohmann dominiklohmann merged commit b05e833 into master Apr 20, 2022
@dominiklohmann dominiklohmann deleted the story/sc-32738/rename-transform-steps branch April 20, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior refactoring Restructuring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants