-
-
Notifications
You must be signed in to change notification settings - Fork 98
Clean up transform steps (and native plugins generally) #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dominiklohmann
merged 18 commits into
master
from
story/sc-32738/rename-transform-steps
Apr 20, 2022
Merged
Clean up transform steps (and native plugins generally) #2228
dominiklohmann
merged 18 commits into
master
from
story/sc-32738/rename-transform-steps
Apr 20, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10beb48
to
07f4b21
Compare
And perform a few touchups here and there.
This solves [sc-31615] in a neat way: It is now rather obvious that code from native plugins must not be used in libvast without going through the plugin API.
2f0628c
to
4d0438f
Compare
mavam
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! CI will sanity-check this.
I have some small cosmetic comments only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on an internal discussion to rename some transform step before the upcoming major release of VAST v2.0 to align their names with what we generally deemed most suitable.
Here's a summary of the changes:
rename
step can now rename fields as well as schemas.where
step supersedes both thefilter
andselect
steps.delete
step is now calleddrop
.project
step is now calledput
.replace
step now supports all complex types that can be inferred.aggregate
step is now calledsummarize
.And lastly, developer-facing only:
CMakeLists.txt
file oflibvast
.libvast
; instead, calls must now go through the plugin API. This supersedes Simplify native plugins setup #2220.📝 Checklist
🎯 Review Instructions
Review the description. Then read the code commit-by-commit.
Before merging this still needs a documentation update.