Remove the "catalog" and "catalog-bytes" keys from the index status #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobim
force-pushed
the
topic/duplicate-catalog-status
branch
from
cad96f2 to
b1830c8
Compare
lava
approved these changes
Apr 25, 2022
The `catalog-bytes` was not updated for removals, so not correct anyways. The `catalog` section is also part of the root document, it doesn't add value to have a duplicate in the `index` section.
tobim
force-pushed
the
topic/duplicate-catalog-status
branch
from
b1830c8 to
b58c86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
catalog-byteswas not updated for removals, so not correct anyways. Thecatalogsection is also part of the root document, it doesn't add value to have a duplicate in theindexsection.📝 Checklist
🎯 Review Instructions
Trivial