Treat list options in env variables consistently #2236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, there were four different ways to handle environment variables for list options: Either through a `caf::config_option_set`, manually split at a colon or a comma, or through the `data` parser. Now, all list options are handled consistently, and can be specified either as single values or as comma-separated lists that support proper escaping. For the `VAST_SCHEMA_DIRS` and `VAST_PLUGIN_DIRS` option this is a subtle breaking change, as they no longer can be specified with a colon-seperator, and commas in the specified directories must now be escaped.
dominiklohmann
force-pushed
the
story/sc-33094/env-config-lists
branch
from
1073acb to
3f7e82b
Compare
mavam
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there were four different ways to handle environment variables for list options: Either through a
caf::config_option_set, manually split at a colon or a comma, or through thedataparser.Now, all list options are handled consistently, and can be specified either as single values or as comma-separated lists that support proper escaping.
For the
VAST_SCHEMA_DIRSandVAST_PLUGIN_DIRSoption this is a subtle breaking change, as they no longer can be specified with a colon-seperator, and commas in the specified directories must now be escaped.📝 Checklist
🎯 Review Instructions
File-by-file. The logic changes in the C++ code should be rather simple to follow. The CMake changes escape
,to\\,in paths.Note that this is a bug-fix, as it aligns the actual behavior with the documented behavior.