Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print segment contents with lsvast #2247

Merged
merged 7 commits into from
Apr 29, 2022
Merged

Print segment contents with lsvast #2247

merged 7 commits into from
Apr 29, 2022

Conversation

lava
Copy link
Member

@lava lava commented Apr 28, 2022 •
edited
Loading

Print the data content of a segment when pointing lsvast directly at it.

Also includes some routine maintenance modernizations of lsvast to adjust to changes in VAST in the meantime.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Review this pull request commit-by-commit.

@lava lava added the feature New functionality label Apr 28, 2022
@lava lava force-pushed the topic/lsvast-segments branch from a0f7088 to f7895b8 Compare April 28, 2022 17:29
dominiklohmann
dominiklohmann approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The lsvast integration test needs to be adapted. I gave this a spin locally for testing and it works as you'd expect.

Considering this is a debug utility only I think we can merge this safely regardless of the release.

@lava lava merged commit 06e52a6 into master Apr 29, 2022
@lava lava deleted the topic/lsvast-segments branch April 29, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominiklohmann dominiklohmann dominiklohmann approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lava @dominiklohmann