-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new debugging features to VAST tools #2260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admittedly I didn't look at the code too much given that it's mostly debug tooling.
The lsvast
changes I played with locally. They probably need to be adapted to include the changes from #2286 as well.
For vast-regenerate
I'm worried about the complexity because we don't test whether it correctly uses the builders. Maybe we can (by default) cause it to write to a separate directory rather than replacing the files in-place?
45d9117
to
b432b3a
Compare
This PR adds some new debugging features to
lsvast
andmdx-regenerate
(which has been renamed tovast-regenerate
) that are helpful when working with index- and mdx-files.📝 Checklist
🎯 Review Instructions