Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new debugging features to VAST tools #2260

Merged
merged 7 commits into from
May 31, 2022

Conversation

lava
Copy link
Member

@lava lava commented May 3, 2022

This PR adds some new debugging features to lsvast and mdx-regenerate (which has been renamed to vast-regenerate) that are helpful when working with index- and mdx-files.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

@lava lava added the feature New functionality label May 3, 2022
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I didn't look at the code too much given that it's mostly debug tooling.

The lsvast changes I played with locally. They probably need to be adapted to include the changes from #2286 as well.

For vast-regenerate I'm worried about the complexity because we don't test whether it correctly uses the builders. Maybe we can (by default) cause it to write to a separate directory rather than replacing the files in-place?

@lava lava force-pushed the topic/lsvast-debugging-improvements branch from 45d9117 to b432b3a Compare May 24, 2022 13:09
@lava lava enabled auto-merge May 24, 2022 13:09
@lava lava merged commit 591e0be into master May 31, 2022
@lava lava deleted the topic/lsvast-debugging-improvements branch May 31, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants