Skip to content

Parse time from JSON strings containing numbers #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2022
Merged

Parse time from JSON strings containing numbers #2340

merged 1 commit into from
Jun 10, 2022

Conversation

dominiklohmann
Copy link
Member

This makes the JSON time/duration conversion even more lenient by also allowing conversion from a string that contains a JSON number.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on docs.tenzir.com/vast, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

The test should cover this.

@dominiklohmann dominiklohmann requested review from rdettai and a team June 10, 2022 14:21
@dominiklohmann dominiklohmann force-pushed the topic/json-time-from-strings branch from 9f68472 to 30447a5 Compare June 10, 2022 14:26
mavam
mavam approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We paired on this. The test just meets the bar. 😉

@dominiklohmann dominiklohmann enabled auto-merge June 10, 2022 14:40
@rdettai
Copy link
Contributor

rdettai commented Jun 10, 2022

also works on my usecase (import from flowlogs going through json)

@dominiklohmann dominiklohmann merged commit 9c17cb7 into master Jun 10, 2022
@dominiklohmann dominiklohmann deleted the topic/json-time-from-strings branch June 10, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

@rdettai rdettai Awaiting requested review from rdettai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dominiklohmann @rdettai @mavam