Compress serialized indexers #2346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around a limitation of FlatBuffers: The maximum size of a FlatBuffers table is 2 GiB. Now while us running into this can be solved by moving indexers to separate files, we can get quite a ways by simply compressing the individual indexers. In my initial measurements, I saw reductions between 2-10x in size of the partition FlatBuffers tables, with partitions containing mostly string indexes compressing best. In limited testing, I was able to bump the max-partition-size from 4 Mi events to 64 Mi events without running into any size limitations, so with this change we should be good for a while, and can even consider bumping the size again.
dominiklohmann
added
performance
dominiklohmann
force-pushed
the
story/sc-34616/compress-indexers
branch
from
37ff36b to
00345e6
Compare
Co-authored-by: tobim <tobim@fastmail.fm>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around a limitation of FlatBuffers: The maximum size of a FlatBuffers table is 2 GiB. Now while us running into this can be solved by moving indexers to separate files, we can get quite a ways by simply compressing the individual indexers.
In my initial measurements, I saw reductions between 2-10x in size of the partition FlatBuffers tables, with partitions containing mostly string indexes compressing best.
In limited testing, I was able to bump the max-partition-size from 4 Mi events to 64 Mi events without running into any size limitations, so with this change we should be good for a while, and can even consider bumping the size again.
📝 Checklist
🎯 Review Instructions
Test with old and newly created databases. Rebuild an older one. Review the code file-by-file.