Emit event and partition metrics from the catalog #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `catalog.num-{events,partitions}` metrics to the output of the
catalog, both containing the schema name and the partition version in the
metrics metadata under `metadata_schema` and `metadata_partition-version`
respectively.
dominiklohmann
force-pushed
the
topic/catalog-metrics
branch
from
ad8cd85 to
74b855a
Compare
tobim
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
catalog.num-{events,partitions}metrics to the output of the catalog, both containing the schema name and the partition version in the metrics metadata undermetadata_schemaandmetadata_partition-versionrespectively.📝 Checklist
🎯 Review Instructions
@tobim we talked about having such a metric this morning, and I happened to need this for debugging another thing I was looking at, so I figured I'd just create a quick PR for this.
I think the review should be straightforward. I tested this locally by looking at the
metrics.logfile and verifying the numbers match what's in the status output.