Implement a flush command
#2396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/sc-34448/flush-command
branch
from
55d5186 to
42c802c
Compare
The new `flush` command causes VAST to decomission all currently active partitions, i.e., write all active partitions to disk immediately regardless of their size or the active partition timeout. This is particularly useful for testing, or when needing to guarantee in automated scripts that input is available for operations that only work on persisted passive partitions. The flush command returns only after all active partitions were flushed to the disk.
Explicit flushing after blocking imports makes many of our integration tests more reliable, reducing the risk of timing-related failures.
dominiklohmann
force-pushed
the
story/sc-34448/flush-command
branch
from
f8ec492 to
6b52021
Compare
dominiklohmann
added
blocked
dominiklohmann
requested review from
lava and
patszt
and removed request for
a team
lava
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
flushcommand causes VAST to decomission all currently active partitions, i.e., write all active partitions to disk immediately regardless of their size or the active partition timeout. This is particularly useful for testing, or when needing to guarantee in automated scripts that input is available for operations that only work on persisted passive partitions.The flush command returns only after all active partitions were flushed to the disk.
📝 Checklist
🎯 Review Instructions
Review changes commit-by-commit.
I recommend only glancing at the second commit, as that shuffles around a lot of integration test reference data because of newly inserted calls to
flush.Code review should be almost trivial. Here's a high-level summary of the changes:
flushcommand plugin that adds a single command without options.(atom::flush) -> voidhandler in the index that decommissions all active partitions.index_state::decommission_active_partitionfunction now takes an optional completion handler so theflushcommand doesn't return too early.