Implement Apache Parquet & Apache Feather V2 stores #2413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
changed the base branch from
master
to
story/sc-17753/parquet-store-plugin
dominiklohmann
force-pushed
the
topic/hackathon-feather-store
branch
3 times, most recently
from
971f12c to
8797ad0
Compare
dispanser
force-pushed
the
topic/hackathon-feather-store
branch
from
03cac3b to
fbf75f5
Compare
dominiklohmann
changed the base branch from
story/sc-17753/parquet-store-plugin
to
master
dominiklohmann
changed the title
dispanser
approved these changes
Jul 11, 2022
There was a problem hiding this comment.
I reviewed the feather implementation, while @dominiklohmann reviewed and approved the parquet changes in #2284 .
dispanser
force-pushed
the
topic/hackathon-feather-store
branch
from
853a9bf to
8a442ef
Compare
This is WIP.
Reorganized code to work with table slices until the actual `write` operation.
In Arrow's debian repositories, parquet is a separate dependency.
In the parquet store, we ignore query hints when evaluating a query, as we don't keep the global IDs around so we can't use them.
This is currently only used for the import time, which is stored per-column, but then on read injected back into the table slices, chosing the max of the entire column.
The IPC format of table slices no longer stores the VAST schema, so the command was not applicable.
This is an important optimization that causes us to persist slices to their IPC backing at a later point in time only, i.e., when actually sending them across the wire. This massively speeds up the performance of the Feather and Parquet stores in most cases, although they're not quite comparable to the Segment store yet because of some further unnecessary materializations.
dispanser
force-pushed
the
topic/hackathon-feather-store
branch
from
8a442ef to
cdf101e
Compare
6 tasks
These changes made a seemlingly unrelated integration tests `Transforms` fail, so in the interest of our RC and other priority work we're delaying looking into this until later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is our monthly Hackathon project, co-authored by @patszt, @dispanser, and @dominiklohmann.
This PR implements an Apache Feather V2 store backend, and simplifies the store plugin to remove all the actor logic from it. It builds upon the in-progress Apache Parquet store backend from #2284.
📝 Checklist
🎯 Review Instructions
Review as a whole. Test extensively on the testbed.