Skip to content

Support dropping entire schemas in drop operator #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2022
Merged

Support dropping entire schemas in drop operator #2419

merged 2 commits into from
Jul 11, 2022

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Jul 11, 2022 •
edited
Loading

The new schemas option allows for dropping entire schemas by name rather than
individual fields by extractors.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on vast.io, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Go file-by-file. The change is trivial.

@dominiklohmann dominiklohmann added the feature New functionality label Jul 11, 2022
@dominiklohmann dominiklohmann requested a review from dispanser July 11, 2022 09:31
@dominiklohmann dominiklohmann force-pushed the story/sc-35299/drop-by-schema branch from 7d8f114 to 3278b2e Compare July 11, 2022 09:33
@dominiklohmann
Support dropping entire schemas in drop operator
21e3baf 
The new `schemas` option allows for dropping entire schemas by name rather than
individual `fields` by extractors.
@dominiklohmann dominiklohmann force-pushed the story/sc-35299/drop-by-schema branch from 3278b2e to 21e3baf Compare July 11, 2022 09:38
mavam
mavam approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the tests and followed the algorithm.

@dominiklohmann @mavam
Make config verficiation more idiomatic
ad96a0c 
Co-authored-by: Matthias Vallentin <matthias@vallentin.net>
@dominiklohmann dominiklohmann enabled auto-merge July 11, 2022 11:57
@dominiklohmann dominiklohmann merged commit 755d3b1 into master Jul 11, 2022
@dominiklohmann dominiklohmann deleted the story/sc-35299/drop-by-schema branch July 11, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavam mavam mavam approved these changes

@dispanser dispanser Awaiting requested review from dispanser

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dominiklohmann @mavam