Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename transform to pipeline #2429

Merged
merged 13 commits into from
Jul 16, 2022
Merged

Conversation

dispanser
Copy link
Contributor

@dispanser dispanser commented Jul 14, 2022

This PR attempts to rename everything related to pipelines which previously went by the name transform.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on vast.io, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

It's difficult to see everything at once; maybe a good place to start is the doc diffs and go from there. Check that all classes and their members (header files) properly reflect the desired changes. There's probably a bunch of local variables that are not renamed properly , as it's difficult to track down al

@dispanser dispanser requested review from lava and mavam July 14, 2022 09:59
@dispanser dispanser added the refactoring Restructuring of existing code label Jul 14, 2022
@dispanser dispanser force-pushed the story/sc-33563/rename-transform-step branch 3 times, most recently from b8eed19 to 2758709 Compare July 14, 2022 11:57
@dispanser dispanser marked this pull request as ready for review July 14, 2022 12:29
@dispanser dispanser changed the title Story/sc 33563/rename transform step Rename transform to pipeline Jul 14, 2022
@dispanser dispanser force-pushed the story/sc-33563/rename-transform-step branch 2 times, most recently from fbd8c36 to 1a8d029 Compare July 15, 2022 05:56
@mavam mavam force-pushed the story/sc-33563/rename-transform-step branch from 6780b6f to d28eef5 Compare July 15, 2022 07:42
@mavam
Copy link
Member

mavam commented Jul 15, 2022

The website build fails, but it's not trivial to resolve. Some links point to a draft blog posts, which the local build via yarn start can handle well, but not when packaging things up with yarn build, which omits the blog post.

The annoying way to fix this is by simply writing down what links need to be changed in the last PR prior to the next release.

@mavam
Copy link
Member

mavam commented Jul 15, 2022

@dispanser maybe replace the last merge commit with a rebase?

@lava lava force-pushed the story/sc-33563/rename-transform-step branch from fb8a1ef to 6c121a0 Compare July 15, 2022 10:34
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; although the PR is huge it is ultimately only renaming things so the potential for errors should be very low.

As far as testing the backwards compatibility goes, I verified that the integration test still passes with an unchanged config file after my changes.

@mavam mavam enabled auto-merge July 15, 2022 12:12
@mavam mavam force-pushed the story/sc-33563/rename-transform-step branch from afdf294 to 6a3a355 Compare July 15, 2022 18:45
@mavam mavam disabled auto-merge July 16, 2022 04:38
@mavam mavam enabled auto-merge July 16, 2022 04:39
@mavam mavam disabled auto-merge July 16, 2022 09:00
@mavam mavam force-pushed the story/sc-33563/rename-transform-step branch from 6a3a355 to c9ff2e4 Compare July 16, 2022 09:02
@mavam mavam enabled auto-merge July 16, 2022 09:02
@mavam mavam disabled auto-merge July 16, 2022 11:02
@mavam mavam removed their request for review July 16, 2022 11:07
@mavam mavam enabled auto-merge July 16, 2022 11:10
@mavam mavam force-pushed the story/sc-33563/rename-transform-step branch from c9ff2e4 to 392535e Compare July 16, 2022 11:19
@mavam mavam merged commit 2fbba66 into master Jul 16, 2022
@mavam mavam deleted the story/sc-33563/rename-transform-step branch July 16, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Restructuring of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants