-
-
Notifications
You must be signed in to change notification settings - Fork 95
Implement optional dense indexes #2430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
75766f4
to
548be12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only looked at the docs so far; I'll leave the actual code review to the rest of the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and very good test coverage!
a693605
to
9d4e212
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs. Just some minor requests for improvements.
Creation and usage of optional dense index can be optional for a given type or field name.
It can be configured in vast.yaml under index in each rule.
By default the index is always created.
📝 Checklist
🎯 Review Instructions
Starting with docs might be useful to grasp what the change is supposed to bring