Skip to content

Implement optional dense indexes #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 8, 2022
Merged

Implement optional dense indexes #2430

merged 8 commits into from
Aug 8, 2022

Conversation

patszt
Copy link
Contributor

@patszt patszt commented Jul 14, 2022

Creation and usage of optional dense index can be optional for a given type or field name.
It can be configured in vast.yaml under index in each rule.
By default the index is always created.

📝 Checklist

  • All user-facing changes have changelog entries.
  • The changes are reflected on vast.io, if necessary.
  • The PR description contains instructions for the reviewer, if necessary.

🎯 Review Instructions

Starting with docs might be useful to grasp what the change is supposed to bring

@patszt patszt added the feature New functionality label Jul 14, 2022
@patszt patszt assigned patszt and unassigned patszt Jul 14, 2022
@patszt patszt changed the title Story/sc 35517 Implement optional dense indexes Jul 15, 2022
@lava lava mentioned this pull request Jul 15, 2022
3 tasks
@patszt patszt force-pushed the story/sc-35517 branch 12 times, most recently from 75766f4 to 548be12 Compare July 20, 2022 07:17
@patszt patszt marked this pull request as ready for review July 20, 2022 07:18
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the docs so far; I'll leave the actual code review to the rest of the team.

Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and very good test coverage!

@patszt patszt force-pushed the story/sc-35517 branch 2 times, most recently from a693605 to 9d4e212 Compare July 22, 2022 17:08
@lava lava added the blocked Blocked by an (external) issue label Jul 22, 2022
Copy link
Member

@dominiklohmann dominiklohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. Just some minor requests for improvements.

@lava lava removed the blocked Blocked by an (external) issue label Aug 8, 2022
@lava lava enabled auto-merge August 8, 2022 11:33
@lava lava merged commit 2fac547 into master Aug 8, 2022
@lava lava deleted the story/sc-35517 branch August 8, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants