Fix vast.export.json.omit-nulls for nested records
#2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `--omit-nulls` option of the JSON export overeagerly removed entire nested records whose first fields was null, instead of just removing the nested field.
dominiklohmann
force-pushed
the
topic/json-omit-nulls-first-nested-element-null
branch
from
ec2f515 to
31b7d49
Compare
tobim
approved these changes
Jul 20, 2022
dominiklohmann
deleted the
topic/json-omit-nulls-first-nested-element-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--omit-nullsoption of the JSON export overeagerly removed entire nested records whose first fields was null, instead of just removing the nested field.📝 Checklist
🎯 Review Instructions
The new unit and integration tests cover this extensively. The code change is rather simple to follow.
Let's increment the number of bugs caused by table slice column access using flat indices rather than offsets and move that up a bit on the roadmap 🙈