Make transform application transactional #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lava
force-pushed
the
story/sc-35706/transforms-duplicate-data
branch
from
da1edec to
d169fbe
Compare
lava
changed the title
lava
force-pushed
the
story/sc-35706/transforms-duplicate-data
branch
from
d169fbe to
3a7c4f7
Compare
dominiklohmann
approved these changes
Jul 28, 2022
mavam
reviewed
Jul 28, 2022
| @@ -23,6 +23,26 @@ | |||
|
|
|||
| namespace vast::system { | |||
|
|
|||
| caf::expected<atom::done> | |||
| posix_filesystem_state::rename_single_file(const std::filesystem::path& from, | |||
| const std::filesystem::path& to) { | |||
There was a problem hiding this comment.
Doesn't rename this more than a single file? Just curious why not go with a plain filesystem rename, which should work for directories as well, no?
There was a problem hiding this comment.
I'm not sure I understand the question. Are you proposing to change the name OR the semantics of this function?
There was a problem hiding this comment.
The name only, because it actually renames directories as well.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
🎯 Review Instructions